Skip to content

add frontier/ethereum example#1557

Merged
niklasad1 merged 4 commits intomasterfrom
na-add-eth-signer-example
Apr 26, 2024
Merged

add frontier/ethereum example#1557
niklasad1 merged 4 commits intomasterfrom
na-add-eth-signer-example

Conversation

@niklasad1
Copy link
Copy Markdown
Contributor

@niklasad1 niklasad1 commented Apr 25, 2024 •
edited
Loading

The ethereum config doesn't work with the default PolkadotConfig which this shows how to do.

Tested with a frontier node

@niklasad1
add ethereum example
77f0053 
The ethereum config doesn't work with the default PolkadotConfig which
this shows how to do.

Tested with a frontier node
@niklasad1 niklasad1 requested a review from a team as a code owner April 25, 2024 08:27
@niklasad1 niklasad1 mentioned this pull request Apr 25, 2024
Closed
jsdw
jsdw reviewed Apr 25, 2024
View reviewed changes
jsdw
jsdw reviewed Apr 25, 2024
View reviewed changes
jsdw
jsdw reviewed Apr 25, 2024
View reviewed changes
jsdw
jsdw approved these changes Apr 25, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

I could have sworn that we had a very similar example somewhere, but I couldn't find it offhand so this looks good to me!

@niklasad1 niklasad1 changed the title add ethereum example add frontier/ethereum example Apr 25, 2024
niklasad1
niklasad1 commented Apr 25, 2024
View reviewed changes
niklasad1
niklasad1 commented Apr 25, 2024
View reviewed changes
@niklasad1
Copy link
Copy Markdown
Contributor Author

niklasad1 commented Apr 25, 2024

@CodiumAI-Agent /improve

@QodoAI-Agent
Copy link
Copy Markdown

QodoAI-Agent commented Apr 25, 2024

PR Code Suggestions

CategorySuggestions                                                                                                                                                       
Enhancement
Make the WebSocket URL configurable to enhance flexibility.

Replace the hardcoded WebSocket URL with a configurable option, allowing flexibility in
specifying different node endpoints.

subxt/examples/tx_basic_frontier.rs [38]

-let api = OnlineClient::<EthRuntimeConfig>::from_insecure_url("ws://127.0.0.1:9944").await?;
+let node_url = std::env::var("NODE_URL").unwrap_or_else(|_| "ws://127.0.0.1:9944".to_string());
+let api = OnlineClient::<EthRuntimeConfig>::from_insecure_url(&node_url).await?;
Replace println! with log::info! for more structured logging.

Use a logging framework instead of println! for better control over logging levels and
outputs.

subxt/examples/tx_basic_frontier.rs [60]

-println!("Balance transfer success: {event:?}");
+log::info!("Balance transfer success: {event:?}");
Add retry logic to network requests to improve reliability.

Consider adding retry logic or a fallback mechanism for network requests to handle
transient errors gracefully.

subxt/examples/tx_basic_frontier.rs [51-54]

-let events = api
-    .tx()
-    .sign_and_submit_then_watch_default(&balance_transfer_tx, &alith)
-    .await?;
+let events = retry::retry_async(retry::delay::Exponential::from_millis(10), || async {
+    api.tx()
+        .sign_and_submit_then_watch_default(&balance_transfer_tx, &alith)
+        .await
+}).await?;
Possible issue
Add error handling for hex encoding to prevent potential runtime panics.

Handle potential errors from the hex::encode function calls to prevent runtime panics in
case of encoding failures.

subxt/examples/tx_basic_frontier.rs [44-45]

-println!("baltathar pub:  {}", hex::encode(baltathar.public_key().0));
-println!("baltathar addr: {}", hex::encode(dest));
+println!("baltathar pub:  {}", hex::encode(baltathar.public_key().0).unwrap_or_else(|e| e.to_string()));
+println!("baltathar addr: {}", hex::encode(dest).unwrap_or_else(|e| e.to_string()));
Best practice
Improve error handling for environment variable retrieval to enhance robustness.

Replace the unwrap calls with proper error handling to avoid panics when environment
variables are not set or have invalid values.

subxt/examples/tx_basic_frontier.rs [38]

-let node_url = std::env::var("NODE_URL").unwrap_or_else(|_| "ws://127.0.0.1:9944".to_string());
+let node_url = std::env::var("NODE_URL").unwrap_or_else(|e| {
+    eprintln!("Error reading NODE_URL: {e}");
+    "ws://127.0.0.1:9944".to_string()
+});
✨ Improve tool usage guide:

Overview:
The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

  • When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:
/improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...

[pr_code_suggestions]
some_config1=...
some_config2=...

See the improve usage page for a comprehensive guide on using this tool.

@niklasad1
Copy link
Copy Markdown
Contributor Author

niklasad1 commented Apr 25, 2024

@CodiumAI-Agent /describe

@niklasad1 niklasad1 merged commit 25193d7 into master Apr 26, 2024
@niklasad1 niklasad1 deleted the na-add-eth-signer-example branch April 26, 2024 14:18
@jsdw jsdw mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsdw jsdw jsdw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@niklasad1 @QodoAI-Agent @jsdw